Change in openvpn[master]: mbedtls: Warn if --tls-version-min is too low
A message that is not in the archive (sent off-list or not yet received): gerrit.1720021020000.Ibc641388d8016533c94dfef3618376f6dfa91f4e@...2715...
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/684?usp=email
to review the following change.
Change subject: mbedtls: Warn if --tls-version-min is too low
......................................................................
mbedtls: Warn if --tls-version-min is too low
Recent versions of mbedtls only support TLS 1.2. When the minimum version is set to TLS 1.0 or 1.1, log a warning and use 1.2 as the actual minimum version.
---
M src/openvpn/options.c
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/84/684/1
src/openvpn/options.c +9 -0
@@ -8942,6 +8942,15 @@msg (msglevel,"unknown tls-version-min parameter: %s" , p[1 ]); goto err; } + +#ifdef ENABLE_CRYPTO_MBEDTLS +if (ver <TLS_VER_1_2 ) + { +msg (M_WARN ,"--tls-version-min %s is not supported by mbedtls, using 1.2" , p[1 ]); + ver =TLS_VER_1_2 ; + } +#endif + options->ssl_flags &= ~(SSLF_TLS_VERSION_MIN_MASK <<SSLF_TLS_VERSION_MIN_SHIFT ); options->ssl_flags |= (ver <<SSLF_TLS_VERSION_MIN_SHIFT );
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/684?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ibc641388d8016533c94dfef3618376f6dfa91f4e
Gerrit-Change-Number: 684
Gerrit-PatchSet: 1
Gerrit-Owner: MaxF <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-MessageType: newchange
Attention is currently required from: MaxF, flichtenheld.
plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/684?usp=email )
Change subject: mbedtls: Warn if --tls-version-min is too low
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/684?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ibc641388d8016533c94dfef3618376f6dfa91f4e
Gerrit-Change-Number: 684
Gerrit-PatchSet: 1
Gerrit-Owner: MaxF <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Attention: MaxF <[email protected]...>
Gerrit-Comment-Date: Wed, 03 Jul 2024 17:13:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
PATCH 1/1 mbedtls: Warn if --tls-version-min is too low
In reply to a message not in the archiveFrom: Max Fillinger <[email protected]...>
Recent versions of mbedtls only support TLS 1.2. When the minimum version is set to TLS 1.0 or 1.1, log a warning and use 1.2 as the actual minimum version.
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/684
This mail reflects revision 1 of this Change.
Acked-by according to Gerrit (reflected above):
Arne Schwabe <[email protected]...>
src/openvpn/options.c +9 -0
@@ -8942,6 +8942,15 @@msg (msglevel,"unknown tls-version-min parameter: %s" , p[1 ]); goto err; } + +#ifdef ENABLE_CRYPTO_MBEDTLS +if (ver <TLS_VER_1_2 ) + { +msg (M_WARN ,"--tls-version-min %s is not supported by mbedtls, using 1.2" , p[1 ]); + ver =TLS_VER_1_2 ; + } +#endif + options->ssl_flags &= ~(SSLF_TLS_VERSION_MIN_MASK <<SSLF_TLS_VERSION_MIN_SHIFT ); options->ssl_flags |= (ver <<SSLF_TLS_VERSION_MIN_SHIFT );
[Openvpn-devel] [PATCH applied] Re: mbedtls: Warn if --tls-version-min is too low
Thanks for that. This fixes my server test rig, which sets --tls-version-min to accept connections from very old clients - it will now (still) fail old clients that can not do TLS 1.2 (namely, OpenVPN 2.2(!) - 2.3 and up are fine), but it will not fail "everything else" as the current code did.
Your patch has been applied to the master branch.
commit c535fa7afe45937bbc7dda435b2b05e57f7ecd53 (master)
Author: Max Fillinger Date: Wed Jul 3 19:41:58 2024 +0200
mbedtls: Warn if --tls-version-min is too low
Signed-off-by: Max Fillinger <[email protected]...>
Acked-by: Arne Schwabe <[email protected]...>
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg28865.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
cron2 has uploaded a new patch set (#2) to the change originally created by MaxF. ( http://gerrit.openvpn.net/c/openvpn/+/684?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: mbedtls: Warn if --tls-version-min is too low
......................................................................
mbedtls: Warn if --tls-version-min is too low
Recent versions of mbedtls only support TLS 1.2. When the minimum version is set to TLS 1.0 or 1.1, log a warning and use 1.2 as the actual minimum version.
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg28865.html
---
M src/openvpn/options.c
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/84/684/2
src/openvpn/options.c +9 -0
@@ -8942,6 +8942,15 @@msg (msglevel,"unknown tls-version-min parameter: %s" , p[1 ]); goto err; } + +#ifdef ENABLE_CRYPTO_MBEDTLS +if (ver <TLS_VER_1_2 ) + { +msg (M_WARN ,"--tls-version-min %s is not supported by mbedtls, using 1.2" , p[1 ]); + ver =TLS_VER_1_2 ; + } +#endif + options->ssl_flags &= ~(SSLF_TLS_VERSION_MIN_MASK <<SSLF_TLS_VERSION_MIN_SHIFT ); options->ssl_flags |= (ver <<SSLF_TLS_VERSION_MIN_SHIFT );
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/684?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ibc641388d8016533c94dfef3618376f6dfa91f4e
Gerrit-Change-Number: 684
Gerrit-PatchSet: 2
Gerrit-Owner: MaxF <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/684?usp=email )
Change subject: mbedtls: Warn if --tls-version-min is too low
......................................................................
mbedtls: Warn if --tls-version-min is too low
Recent versions of mbedtls only support TLS 1.2. When the minimum version is set to TLS 1.0 or 1.1, log a warning and use 1.2 as the actual minimum version.
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg28865.html
---
M src/openvpn/options.c
1 file changed, 9 insertions(+), 0 deletions(-)
src/openvpn/options.c +9 -0
@@ -8942,6 +8942,15 @@msg (msglevel,"unknown tls-version-min parameter: %s" , p[1 ]); goto err; } + +#ifdef ENABLE_CRYPTO_MBEDTLS +if (ver <TLS_VER_1_2 ) + { +msg (M_WARN ,"--tls-version-min %s is not supported by mbedtls, using 1.2" , p[1 ]); + ver =TLS_VER_1_2 ; + } +#endif + options->ssl_flags &= ~(SSLF_TLS_VERSION_MIN_MASK <<SSLF_TLS_VERSION_MIN_SHIFT ); options->ssl_flags |= (ver <<SSLF_TLS_VERSION_MIN_SHIFT );
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/684?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ibc641388d8016533c94dfef3618376f6dfa91f4e
Gerrit-Change-Number: 684
Gerrit-PatchSet: 2
Gerrit-Owner: MaxF <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged